Refactored PyPortal to use PortalBase #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
FoamyGuy
reviewed
Jan 9, 2021
There was a problem hiding this comment.
I tested this successfully with the simpletest, as well as "PyPortal User Interface" and "PyPortal Bitcoin" learn guide projects. Everything working well on all of those.
On the Cleveland art photo learn project I did find an error using this version of the library though:
Traceback (most recent call last):
File "code.py", line 32, in <module>
File "/lib/adafruit_pyportal/__init__.py", line 149, in __init__
AttributeError: 'PyPortal' object has no attribute '_debug'
Looks like a good start to the refactor to me.Thanks for working on this!
|
Thanks for finding that @FoamyGuy. |
|
I've been running the weather demo on my PyPortal over the weekend without issues. |
|
Ok, I feel good about this PR. It will continue to fail checks until adafruit/Adafruit_CircuitPython_PortalBase#8 is merged in and released. |
FoamyGuy
approved these changes
Jan 12, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 12, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 5.0.0 from 4.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#99 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#100 from makermelissa/fix-precommit > Added pre-commit-config file > Added pre-commit and SPDX copyright Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_TM#1 from adeanzan/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.0.3 from 5.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#61 from mstaack/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#8 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires adafruit/Adafruit_CircuitPython_PortalBase#8 to work. Making a draft for the moment until I can do some more thorough testing.