Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate buffer management into PixelBuf. #10

Open
wants to merge 3 commits into
base: master
from

Conversation

@tannewt
Copy link
Contributor

tannewt commented Jan 23, 2020

Also provide show() and fill() on the super class.

This is compatible with the previous PixelBuf API by accepting buf and
rawbuf in the constructor, allowing show() to be shadowed and providing
fill at the top level.

Libraries should not release based on the new API until the built-in _pixelbuf is also updated.

Also provide show() and fill() on the super class.

This is compatible with the previous PixelBuf API by accepting buf and
rawbuf in the constructor, allowing show() to be shadowed and providing
fill at the top level.
@tannewt tannewt requested a review from caternuson Jan 23, 2020
@caternuson

This comment has been minimized.

Copy link
Contributor

caternuson commented Jan 23, 2020

Looks good.

I also did a local update of NeoPixel_SPI based on these changes to test it out. Works as expected. I did not test anything related to DotStar.

I'll let you deal with the linter in whatever way best suits you. :)

tannewt added 2 commits Jan 24, 2020
@caternuson

This comment has been minimized.

Copy link
Contributor

caternuson commented Jan 25, 2020

Not part of your PR, but made me look - what's the purpose of called in the example?

@tannewt

This comment has been minimized.

Copy link
Contributor Author

tannewt commented Jan 27, 2020

@caternuson It's there to ensure that _transfer is called by the PixelBuf implementation. It is a bit tricky to do in the native code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.