-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animated Gif Player Performance improvements #61
Comments
good idea, time.monotonic() ftw :) |
time.monotonic is now implemented. I'll keep this open for a while longer to continue listing ideas. |
A side note on speed improvements: I first tried this repo without numpy installed and a call to IMO you could/should output a warning when numpy is not available as I was almost giving up this repo because of speed issues. |
@philippkeller we should import numpy in the main script to 'force' it to install, wanna submit that as a PR? |
I also added a section to the guide the other day suggesting NumPy be installed installed in the setup, but I like the suggestion of just adding an unused import. |
I think I'm going to close this. I was able to run this at a good speed on the Pi 4. The latest SPI addition in PureIO really helped and the code is pretty optimized at this point. |
I mostly want to list ideas here for performance improvement ideas. The first idea I had is taking the image loading time into account for the delay. At the moment it loads the images, then does a delay. This change should have a significant impact.
The text was updated successfully, but these errors were encountered: