Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text #67

Open
wants to merge 12 commits into
base: master
from
Open

Add text #67

wants to merge 12 commits into from

Conversation

@TG-Techie
Copy link

TG-Techie commented Jan 17, 2020

add text support to the library in a fast manner

work in progress pylint wise, but I put it up here for review/suggestion and food for thought

the text function could really be broken into more parts, I just figured it would be better to get it working (it's just long, for now ). also added scaling into _block so the scaling feature wasn't limited text

TG-Techie added 12 commits Jan 14, 2020
@TG-Techie TG-Techie changed the title Add text TG-Techie: Add text Jan 17, 2020
@TG-Techie TG-Techie changed the title TG-Techie: Add text Add text Jan 17, 2020
@FoamyGuy

This comment has been minimized.

Copy link

FoamyGuy commented Jan 24, 2020

I tested this out starting from the sample code from here with a Feather M4 Express + 2.4" TFT Featherwing.

I am getting this error from the sample code when I switch to this version of the library:

  File "/lib/adafruit_rgb_display/ili9341.py", line 94, in __init__
  File "/lib/adafruit_rgb_display/rgb.py", line 568, in __init__
  File "/lib/adafruit_rgb_display/rgb.py", line 163, in __init__
  File "/lib/adafruit_rgb_display/rgb.py", line 618, in rotation
Exception: rotation not currently supported for this display, see datasheet
@makermelissa makermelissa self-requested a review Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.