Fixed example for RPLidar firmware 1.29 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also corrected package name and removed unnecessary pygame stuff
|
yay awesome for the community working together! |
|
Fixing CRLF wasn't working through web interface and I finally figured out how to correctly push remotely to another user's repo through command line. |
|
Thanks @makermelissa! It's weird that the linter was rejecting the line endings. I just edited the file in Github's own web editor! |
|
Yeah, same here initially. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 6, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_RPLIDAR to 1.2.0 from 1.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_RPLIDAR#17 from zlite/master > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.2.5 from 5.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#73 from flavio-fernandes/fix.validate_feed_key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses latest PR from @makermelissa
Fixed example to include timeout=3, which is necessary on latest firmware. Some other fixes to example, such as corrected package name since it does not currently support circuitpython.
Tested on RPLidar firmware 1.29 and the previous firmware, 1.27, so should work on all RPLidars now