Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UV Index, use adafruit_register #8

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Add UV Index, use adafruit_register #8

merged 4 commits into from
Aug 10, 2022

Conversation

tekktrik
Copy link
Member

Accidentally closed while attempting to rebase changes in #4, so here's a new PR.

@tekktrik tekktrik changed the title Dev/add uv index Add UV Index, use adafruit_register Aug 10, 2022
@tekktrik
Copy link
Member Author

I haven't tested this code, but I can get a device on order if needed, just a heads up.

tannewt
tannewt approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Any idea how much memory is saved by this?

@tekktrik
Copy link
Member Author

No, but I'm looking up ways to try it out, beyond just looking at the MPY filesize for an estimate.

@tekktrik tekktrik merged commit 216640c into adafruit:main Aug 10, 2022
@caternuson caternuson mentioned this pull request Aug 10, 2022
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 11, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c39ffe7)
947d95d 
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#8 from tekktrik/dev/add-uv-index

Updating https://github.com/adafruit/Adafruit_CircuitPython_BitbangIO to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#23 from tcfranks/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@caternuson caternuson Awaiting requested review from caternuson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tekktrik @tannewt