Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with display.root_group for CircuitPython 9 compatibility #7

Merged
merged 9 commits into from
Feb 20, 2024

Conversation

prcutler
Copy link
Contributor

@prcutler prcutler commented Nov 2, 2023

This PR replaces display.show with display.root_group in the 4 example files and the README

Copy link

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too am rather baffled by

Warning, treated as error:
/home/runner/work/Adafruit_CircuitPython_SPD1656/Adafruit_CircuitPython_SPD1656/adafruit_spd1656.py:docstring of adafruit_spd1656.SPD1656:15:'any' reference target not found: displayio.FourWire
Error: Process completed with exit code 2.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Nov 2, 2023

I think this error is somehow due to the superclass that is being extended by this

class SPD1656(displayio.EPaperDisplay):

I'm not entirely sure why that error comes up. I think sphinx is using Blinka_DisplayIO for it's knowledge of displayio which doesn't have the latest chagnes / split up from the core I think. So perhaps that ties into this somehow.

In any case I think EPaperDisplay was moved with that recent change as well so this line should probably be updated to:

class SPD1656(epaperdisplay.EPaperDisplay): 

I tested out this doc build locally and found that if I add epaperdisplay (or displayio if that isn't changed) to the list of mock modules here in the docs conf.py file: https://github.com/adafruit/Adafruit_CircuitPython_SPD1656/blob/main/docs/conf.py#L30 it will allow the docs to build successfully.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one commit to change this to use the new epaperdisplay module.

This looks good to me.

@FoamyGuy FoamyGuy merged commit 901318c into adafruit:main Feb 20, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 27, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL37x to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADXL37x#5 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 7.0.0 from 6.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#188 from justmobilize/remove-set-socket

Updating https://github.com/adafruit/Adafruit_CircuitPython_GUVX_I2C to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_GUVX_I2C#5 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.1.16 from 1.1.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#30 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8574 to 1.0.9 from 1.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8574#8 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8575 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8575#7 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_SPD1656 to 0.9.0 from 0.8.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SPD1656#7 from prcutler/root-group-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.13 from 1.2.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#19 from prcutler/root-group-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_UC8151D to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_UC8151D#13 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 2.0.0 from 1.1.22:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#26 from standsi/SetInitialLightGain

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.1.14 from 1.1.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#16 from analogic/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L4CD to 1.2.0 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L4CD#9 from markkamp/measurement_quality

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Beacon to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Beacon#3 from FoamyGuy/fix_circup_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 2.0.0 from 1.16.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#100 from justmobilize/remove-set-socket

Updating https://github.com/adafruit/Adafruit_CircuitPython_Radial_Controller to 1.0.12 from 1.0.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_Radial_Controller#3 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 3.0.0 from 2.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#151 from justmobilize/connection-manager

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert .show() to .root_group = for CircuitPython 9
3 participants