-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory_optimization #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this optimization needed for a specific use case? I don't think it's bad or anything, but I do know that other libraries use the CV
method to emulate enum-like behavior.
I think it's worth bringing up how to bets optimize this. Another solution would be to create a library that provides this functionality, as currently if you use multiple libraries that have it then it's just duplicated. This Arduino-like "definition" solution would also work though, but has the drawback of being slightly un-Pythonic since the enum-like behavior of Category.SELECTION
is appealing and very user-friendly. Definitely would want to hear what others have to say.
Hiya, optimization is needed for M0 boards where the library currently does not fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotchyha, thanks for clarifying! I added some feedback below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert this back to 719aebd since I think it's better to have getters return the same thing (e.g., if obj.x = 4
, then x = obj.x
should also be 4
) That makes comparisons much easier as well. I also added a comment or two above!
Reverted to desired state after having some quality time with GIT 😮💨 |
For a QT PY M0, you must use the mpy file. closes #11
These are breaking changes. Learning Guide probably need updating.
Tested with examples.
Initial test code:
Results