Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements "High Bit Depth Gamma Correction Algorithm for APA102/Dotstar LEDs" for the Adafruit Dotstar library. #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zackees
Copy link

@zackees zackees commented Oct 23, 2023

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

This is a code-style review. Right now the compilation tests pass. However, the way I've implemented this into the main object may not be exactly what the Adafruit team has in mind. So this PR at this time is to do a check-in and see if the way I've implemented is ok, or whether I should change it. If the style is ok, then I'll do final testing with a physical unit. Note that I've already done physical device testing with this change for the FastLED library PR and so i expect the testing to be straightforward and work on the first try.

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.

    This implements the "High Bit Depth Gamma Correction Algorithm for APA102/Dotstar LEDs"

  • Describe any known limitations with your change.

This is portable c code implementation. However, I do add a gamma16 function which is 256*sizeof(uint16_t) units in prog memory.

  • Please run any tests or examples that can exercise your modified code.

I've added a new test .ino file. Please see onboard_hd.ino

@zackees zackees changed the title adds five bit hd gamma to adafruit. Implements "High Bit Depth Gamma Correction Algorithm for APA102/Dotstar LEDs" for the Adafruit Dotstar library. Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant