Add support for panels with FM6126A chipset. Copied from SmartMat…

[colorama]

Not sure if anyone needs it, but I have a bunch of these panels and now they work. Yay.
The fix adds one function - copied from SmartMatrix. Have not tested with 'normal' panels - I don't have any.
Might need to make this into an 'option'.

[PaintYourDragon]

Thank you. I have Normal Panels here and could test, but first, some changes I would request:

• Please declare the new function as static and include PM at the start, just a pedantic thing in the library to say “internal function.”
• The reset function can go above the #if defined(ARDUINO) || defined(CIRCUITPY) block, since nothing in here is platform-dependent.
• Plz run through clang-format to match the formatting favored by the continuous integration tools.
• I realize this is copied over from the SmartMatrix library, so I’m not placing any blame here, but the implementation is pretty bloaty and what I might ask is if you could re-test later after I’ve given it a going-through (since I don’t have any FM6126A panels here).

If that’s all bothersome, no worries and we are grateful for the contribution nonetheless…another option then is to keep a fork with your changes as they are, which can track and keep up with changes in the mainline code.
Thanks!

[colorama]

Perhaps #define for loops is not awesome - feel free to change ;-)

[colorama]

Also... I obviously have no idea what this code does - things like hardcoded maxLeds and the various offsets, etc w/o comments are not great. Regrettably, I don't have time to investigate further.

[PaintYourDragon]

Tested on “classic” panel, seems OK! Thank you! Will merge this in a moment but NOT bump the release # just yet — will make some small changes of my own and check back with you that it still works on the FM6126A panels

[PaintYourDragon]

Howdy. OK, startup/reset is simplified a bit, code’s in main branch but NOT Arduino lib manager yet. If you could check on the FM panels you have, and confirm whether it still works there, I’ll bump the version # which should send it out. Thx!

[colorama]

Pulled master and verified with Arduino - FM panels and "classic". All good 👍🏻

Related question: tried to verify with circuit python, so I pulled master of circuitpython and tried building for matrIxportal_m4 with:
make BOARD=matrixportal_m4

After copying the firmware to the board (cp firmware.uf2 /Volumes/MATRIXPORTAL), the board reboots, but does not mount as CIRCUITPY.

Any pointers? Thanks!

[PaintYourDragon]

Woot, thanks.

Not sure what’s up with CircuitPython. Is this an artifact of the matrix code changes, or does this happen even with the prior code?

[colorama]

Yeah, that's with TOT code. I'll try pulling an earlier tag.

[PaintYourDragon]

Possibly related: changes were recently made for ESP-IDF 5.0.

[colorama]

Same difference with 7.3.3. I must be doing something wrong. Just following instructions here:
https://learn.adafruit.com/building-circuitpython/build-circuitpython

[PaintYourDragon]

Probably not you. CircuitPython’s a bit beyond me, but you can try asking in the forums.