This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Added modifiable long delay for use in clear and home operations. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagated change to other classes and switched to use a master long delay constant Added forgotten constant declaration
|
Increasing the delay finally solves my display hassle with crypty characters too. Useful feature, should be integrated! UPVOTE! ;-) |
|
It's been quite a while since there was no response from the owner. I don't think this project is maintained. There seems to be a conflict, but I'm not gonna bother resolving if the owner doesn't bother to check these. Would just be a waste of time. |
|
Thank you for the PR! However, we're moving to a new library. Please see the response on #28 for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagated change to other classes and switched to use a master long delay constant
This closes issue #28
Scope: This change moves the default delay value of 3000 us into a new constant declaration named DEFAULT_LONG_DELAY_US. This default constant is now used in the home() and clear() methods of the base Adafruit_CharLCD class. Furthermore, the base class and all subclasses allow adjustment of this value in the case that the delay value is too short by default for long operations.
Limitations: No limitations. This is only changing primitive declarations.
Examples/tests: Default examples satisfy normal initialization and this affects only a subset of users that have issues with the delay on long operations (clear() and home()) taking too little time for the device to properly clear or move the cursor.