This repository has been archived by the owner on Nov 12, 2019. It is now read-only.
Fixed the magic-number delay #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you warned in comments, it was constantly a low level in this place for my hardware. For me the delay is 70, not 50. So I advice you to avoid magic numbers and check the level directly in an endless cycle. Please decorate it with some error code if you like, but the original gode does not work. It took an evening for me to figure up why.
|
Note that I also changed the platform identification constants, because my RPi1 was detected as RPi3. Maybe this change deserves another PR, but I'm not sure that this one has a chance to be approved after two years, so there's no difference. |
|
@Himura2la thanks for the contribution here, and I apologize you haven't seen a response sooner. I'm closing this and related PRs as we're working on deprecating this library in favor of Adafruit_CircuitPython_DHT. |
|
Wow, that's unexpected. Ok) |
|
To clarify, we'll keep supporting this library on the Pi 1 and 2, at least until we get the CircuitPython library working acceptably on older hardware. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you warned in comments, it was constantly a low level in this place
for my hardware. For me the delay is 70, not 50. So I advice you to
avoid magic numbers and check the level directly in an endless cycle.
Please decorate it with some error code if you like, but the original
сode really does not work in some cases. It took an evening for me to figure up why.