New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the magic-number delay #24

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@Himura2la

Himura2la commented Jun 29, 2015

As you warned in comments, it was constantly a low level in this place
for my hardware. For me the delay is 70, not 50. So I advice you to
avoid magic numbers and check the level directly in an endless cycle.
Please decorate it with some error code if you like, but the original
сode really does not work in some cases. It took an evening for me to figure up why.

Himura2la added some commits Jun 29, 2015

Fixed the magic-number delay
As you warned in comments, it was constantly a low level in this place
for my hardware. For me the delay is 70, not 50. So I advice you to
avoid magic numbers and check the level directly in an endless cycle.
Please decorate it with some error code if you like, but the original
gode does not work. It took an evening for me to figure up why.
@Himura2la

This comment has been minimized.

Show comment
Hide comment
@Himura2la

Himura2la May 18, 2017

Note that I also changed the platform identification constants, because my RPi1 was detected as RPi3. Maybe this change deserves another PR, but I'm not sure that this one has a chance to be approved after two years, so there's no difference.

Himura2la commented May 18, 2017

Note that I also changed the platform identification constants, because my RPi1 was detected as RPi3. Maybe this change deserves another PR, but I'm not sure that this one has a chance to be approved after two years, so there's no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment