Skip to content
This repository has been archived by the owner. It is now read-only.

Fixed the magic-number delay #24

Closed
wants to merge 5 commits into from
Closed

Conversation

Himura2la
Copy link

@Himura2la Himura2la commented Jun 29, 2015

As you warned in comments, it was constantly a low level in this place
for my hardware. For me the delay is 70, not 50. So I advice you to
avoid magic numbers and check the level directly in an endless cycle.
Please decorate it with some error code if you like, but the original
сode really does not work in some cases. It took an evening for me to figure up why.

Himura2la and others added 5 commits Jun 29, 2015
As you warned in comments, it was constantly a low level in this place
for my hardware. For me the delay is 70, not 50. So I advice you to
avoid magic numbers and check the level directly in an endless cycle.
Please decorate it with some error code if you like, but the original
gode does not work. It took an evening for me to figure up why.
@Himura2la
Copy link
Author

@Himura2la Himura2la commented May 18, 2017

Note that I also changed the platform identification constants, because my RPi1 was detected as RPi3. Maybe this change deserves another PR, but I'm not sure that this one has a chance to be approved after two years, so there's no difference.

@brennen
Copy link
Contributor

@brennen brennen commented Nov 2, 2018

@Himura2la thanks for the contribution here, and I apologize you haven't seen a response sooner. I'm closing this and related PRs as we're working on deprecating this library in favor of Adafruit_CircuitPython_DHT.

@brennen brennen closed this Nov 2, 2018
@Himura2la
Copy link
Author

@Himura2la Himura2la commented Nov 2, 2018

Wow, that's unexpected. Ok)

@brennen
Copy link
Contributor

@brennen brennen commented Nov 2, 2018

To clarify, we'll keep supporting this library on the Pi 1 and 2, at least until we get the CircuitPython library working acceptably on older hardware.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants