Adding NXP NavQPlus to detected boards #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the chip is already detected) Future boards using the same SOC may need to edit the board name or detection line in bin/detect.py so it doesn't list it as an NXP NAVq board Original NavQ board not available to I couldn't add it too. Added for the Hovergames 3 Team Mcfly 2023 Changes to be committed: modified: adafruit_platformdetect/board.py modified: adafruit_platformdetect/constants/boards.py modified: bin/detect.py
|
@makermelissa Can you review this when you have time please? |
…ions when I add it into Blinka Changes to be committed: modified: adafruit_platformdetect/board.py modified: adafruit_platformdetect/chip.py modified: adafruit_platformdetect/constants/chips.py
|
Can you run pre-commit so that it fixes the formatting and the checks pass? Otherwise, the code itself looks good. |
|
Sorry about that @makermelissa. I started looking at the Blinka code and found I need to detect this board separately. Otherwise some of the GPIO and UART numbers won't line up and I didn't want to risk breaking existing code. I didn't realize Github auto-adds to the Pull Request when I pushed in the new commits. |
|
Awesome. Did you want me to wait before merging this? |
|
No, if you don't see any issues it can be merged. |
makermelissa
approved these changes
Mar 17, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dding the NXP NavQPlus board:
Board documentation available here:
(Based on the the NXP i.MX 8M Plus SOC so the chip is already detected)
Future boards using the same SOC may need to edit the board name or detection line in bin/detect.py so it doesn't list it as an NXP NavQ based board
Tested on Ubuntu 22.04 built on top of NXP Yocto 5.15
Added for the Hovergames 3
Team McFly
2023
Instructions followed : https://learn.adafruit.com/adding-a-single-board-computer-to-platformdetect-for-blinka/overview