Move Raspberry Pi detection out of board.py #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please refer to Issue 296 for more information.
This reverts commit da10cd9.
The motivation for this change was to reduce the size of board.py.
More extensive refactoring is required to resolve this.
NathanY3G
changed the title
|
I suggest we close this MR since it is not currently needed. I can always create a new MR if required. Any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial MR for issue #296.
I have attempted to minimize any changes to the existing detection code during it's relocation.
Tested by running
detect.pywith these changes to successfully identify a Pi 4B, a classic Pi and a Compute Module 4.