Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODROID-M1: Remove RK3568B2 and Use RK3568 instead #331

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

how2flow
Copy link
Contributor

@how2flow how2flow commented Dec 6, 2023

The prefixes for the 'compatible' property of rk3568 are all patterns of the form 'rockchip, rk3568-*'. 'rockchip, rk3568b2' does not seem appropriate.

Signed-off-by: Steve Jeong <steve@how2flow.net>
Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makermelissa
Copy link
Contributor

makermelissa commented Dec 7, 2023

Hi, sorry about the delay. There was some talk about changing boards from RK3588 to RK3588S and I misread the number on this.

@makermelissa makermelissa merged commit 47efdb5 into adafruit:main Dec 7, 2023
1 check passed
@cybershoe
Copy link

cybershoe commented Dec 7, 2023

Looks like this is breaking adafruit_blinka.microcontroller.pin, it's still referencing the RK3568B2 constant from constants.chips

>>> import microcontroller
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/adam/src/minihass/venv/lib/python3.10/site-packages/microcontroller/__init__.py", line 16, in <module>
    from microcontroller import pin  # pylint: disable=unused-import
  File "/home/adam/src/minihass/venv/lib/python3.10/site-packages/microcontroller/pin.py", line 117, in <module>
    elif chip_id == ap_chip.RK3568B2:
AttributeError: module 'adafruit_platformdetect.constants.chips' has no attribute 'RK3568B2'. Did you mean: 'RK3568'?

cybershoe added a commit to cybershoe/Adafruit_Python_PlatformDetect that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants