Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CO2, eCO2 sensor types #45

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Add CO2, eCO2 sensor types #45

merged 2 commits into from
Mar 3, 2023

Conversation

brentru
Copy link
Member

@brentru brentru commented Mar 3, 2023

Resolves #44

@brentru brentru merged commit 355dde3 into adafruit:master Mar 3, 2023
@brentru brentru deleted the add-eco2 branch March 3, 2023 16:00
@caternuson
Copy link

Can leave library.properties unchanged. Whoever comes along to make the next release can deal with that.

Totally cosmetic - should it be all caps?

SENSOR_TYPE_ECO2

@caternuson
Copy link

oops. nvm. been merged.

@brentru
Copy link
Member Author

brentru commented Mar 3, 2023

@caternuson Will address in branch i'm checking out,

Totally cosmetic - should it be all caps?

Yeah I believe so, will update this here: #46

I'm going to cut a release shortly so I'd like .properties updated. For next time - are we leaving .properties alone for non-urgent releases?

@caternuson
Copy link

In general, yah, I think leave library.properties alone in the actual PR. Sometimes a release may be multiple PRs merged in no particular order. Or other reasons that may warrant a different sem ver number. And it's trivial to edit library.properties right before an actual release (i just use github's web edit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for CO2, eCO2
2 participants