Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Feather HUZZAH ESP8266 Inverted LED PWM #511

Merged
merged 2 commits into from Nov 24, 2023

Conversation

brentru
Copy link
Member

@brentru brentru commented Nov 24, 2023

Resolves #495 by inverting the analog write calculation for the Adafruit Feather ESP8266 HUZZAH

@brentru brentru requested a review from tyeth November 24, 2023 11:55
Copy link
Contributor

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could benefit from an update to comment for clarity

@brentru brentru merged commit ad6ac41 into adafruit:main Nov 24, 2023
31 checks passed
@brentru brentru deleted the fix-inverted-led-pwm branch November 24, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Dimmable LED" Component on HUZZAH ESP8266 is inverted
2 participants