Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nanopb installation to CI #519

Merged
merged 6 commits into from Dec 8, 2023
Merged

Add nanopb installation to CI #519

merged 6 commits into from Dec 8, 2023

Conversation

brentru
Copy link
Member

@brentru brentru commented Dec 7, 2023

Resolves #518

@brentru brentru marked this pull request as ready for review December 7, 2023 22:48
@brentru brentru requested a review from tyeth December 7, 2023 22:48
tyeth
tyeth approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@tyeth tyeth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that all makes sense. Initially a bit curious about their releases etc, but I see now. Only question I had was why move instead of copy that one file, but I missed it was a rename.

@brentru
Copy link
Member Author

brentru commented Dec 8, 2023

@tyeth move makes more sense in the context that's a move and rename.

@brentru brentru merged commit 908eae0 into adafruit:main Dec 8, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyeth tyeth tyeth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure WipperSnapper is build with latest stable release of nanopb
2 participants
@brentru @tyeth