fix issue with blitFrameBuffer not working on Adafruit CLUE (HT @jimsbugs) #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
reviewed
Dec 24, 2021
hathach
reviewed
Dec 29, 2021
There was a problem hiding this comment.
excellent and very detailed explanation. Thank you very much for the PR. Since this issue affects all variants, so we should apply the change for all, would you mind push update to drop the cast entirely for all variants.
// each transfer can only up to 64KB (16-bit) bytes
const size_t xfer_len = min(count, UINT16_MAX);
hathach
approved these changes
Dec 29, 2021
|
Thanks for the excellent fix/explanation @jimsbugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue identified here https://forums.adafruit.com/viewtopic.php?f=65&t=185669 where blitFrameBuffer hangs on Adafruit CLUE