Add New Board: Raytac MDBT50Q Demo Board 40 #233
Conversation
markbirss
commented
Nov 25, 2021
markbirss
commented
- adding Raytac MDBT50Q Demo Board 40 files
Add Board support for Raytac MDBT50Q Demo Board 40
Fix UF2_VOLUME_LABEL too long
| #define USB_DESC_VID 0x239A | ||
| #define USB_DESC_UF2_PID 0x010C | ||
| #define USB_DESC_CDC_ONLY_PID 0x010C |
There was a problem hiding this comment.
it is required by this repo that each board must have its own unique VID/PID. I double check, but this PID isn't assigned by Adafruit to any boards yet. Please try to get one from PID donor.
|
Ok, i understand your comment, but what is "PID donor" ? |
I mean you could ask from one of the manufacturer to get an PID assigned to this board. |
|
Ok, will ask Raytac about it |
|
The device was loaded with this when i received it |
|
@hathach Ok, i just found this github issue about the same thing for circuitpython for the same device adafruit/circuitpython#3128 (comment) This suggests I must use PID 0x00BB # bootloader ? |
|
@markbirss it is the same board, so yes, we should/must use that PID. Please update your PR |
Changed PID taken from adafruit/circuitpython#3128 (comment)
|
Sure, i have made the required change |
| //------------- UF2 -------------// | ||
| #define UF2_PRODUCT_NAME "Raytac MDBT50Q Demo Board 40" | ||
| #define UF2_VOLUME_LABEL "MDBT50QBOOT" | ||
| #define UF2_BOARD_ID "RAYTAC-MDBT50Q-DB-40" |
There was a problem hiding this comment.
board id must follow uf2 format
There was a problem hiding this comment.
@hathach
Im not sure I understand your comment ?
Looking at the other already defined Raytec Board, what is the board-id you referring to ?
//------------- UF2 -------------//
#define UF2_PRODUCT_NAME "Raytac MDBT50Q-RX"
#define UF2_VOLUME_LABEL "MDBT50QBOOT"
#define UF2_BOARD_ID "nRF52840-MDBT50Q_RX-verD"
#define UF2_INDEX_URL "https://www.adafruit.com/product/5199"
There was a problem hiding this comment.
board-id must follow format dictate by uf2 spec https://github.com/microsoft/uf2#files-exposed-by-bootloaders
There was a problem hiding this comment.
@hathach Ok, for your review, made changes to UF2_BOARD_ID
from https://github.com/microsoft/uf2#files-exposed-by-bootloaders The Board-ID field is machine-readable and consists of a number of dash-separated tokens. The first token is the CPU type, second is the board type, and third is the board revision. More tokens can be also added.
There was a problem hiding this comment.
everything look good, only one last thing: you need add the board to ci list so that its binaries is generated when released https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml
