Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for the Makerdiary nRF52840 Connect Kit board #309

Merged
merged 5 commits into from Aug 1, 2023

Conversation

markbirss
Copy link
Contributor

This PR adds support for the Makerdiary nRF52840 Connect Kit board.

Matches the format of the existing Makerdiary Pitaya Go board

https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/src/boards/pitaya_go/board.h

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks and please update PR according to review. Once done, please also add your board to the ci list as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml

src/boards/nRF52840_connect_kit/board.h Outdated Show resolved Hide resolved
src/boards/nRF52840_connect_kit/board.h Outdated Show resolved Hide resolved
changes requested to board-id
Copy link
Contributor Author

@markbirss markbirss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the changes, ok, i must await makerdiary response?

@markbirss markbirss requested a review from hathach July 20, 2023 15:54
@hathach
Copy link
Member

hathach commented Jul 21, 2023

are the changes, ok, i must await makerdiary response?

thanks, it looks good, though you need to add this board to the ci yml as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml

@markbirss
Copy link
Contributor Author

are the changes, ok, i must await makerdiary response?

thanks, it looks good, though you need to add this board to the ci yml as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml

Sure
#311

@markbirss markbirss closed this Jul 21, 2023
@markbirss markbirss reopened this Jul 21, 2023
@hathach
Copy link
Member

hathach commented Jul 21, 2023

please push the ci yml changes as part of this pr

@markbirss
Copy link
Contributor Author

markbirss commented Jul 21, 2023

@hathach
Ok, i updated githubci.yml

@markbirss
Copy link
Contributor Author

@hathach

anything else need to be fixed ?

@hathach
Copy link
Member

hathach commented Aug 1, 2023

@hathach

anything else need to be fixed ?

vid, pid confirmation

@markbirss
Copy link
Contributor Author

@hathach

OK, will follow up my request i sent to makerdiary

@markbirss
Copy link
Contributor Author

markbirss commented Aug 1, 2023

@hathach

Response from Makerdiary

Our partner SeeedStudio has assigned us 2886:F001~2886:F00F, and we give nRF52840-Connect-Kit UF2 Bootloader the 2886:F00F.

makerdiary/nrf52840-connectkit#2 (comment)

@markbirss
Copy link
Contributor Author

@hathach

I have updated board.h with the confirmed VID:PID

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is good

@hathach hathach merged commit 7210c39 into adafruit:master Aug 1, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants