New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definition for Sensirion SGP30 #129
Conversation
@tyeth perfect, thanks for this work and the note. I've just added a commit with the @brentru I was looking at this list to see what all sensor types are in there: We don't seem to be one-for-one with that list, is that expected? Or should we try to match that closely? |
Other places to update:
|
Seen the file size image issue, woops forgot that bit, only remembered a limit for GIFs. |
@lorennorman I no longer have the ability to rerun due to your commit touching restricted files, but should be fine. |
@lorennorman @tyeth Enumerated type for TVOC has been added within WipperSnapper_Protobuf and wrappers have been compiled and merged into WipperSnapper_Arduino. |
@tyeth You should be un-blocked and able to continue. Please leave @lorennorman and I any notes in here if you are still encountering issues with the broker/types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@brentru @lorennorman
There's a minor hiccup:
The schema for the i2c component subtypes doesn't have TVOC, but it is included in the Adafruit_Sensor repo, so I assume that's the correct value to use, along with eco2 for the SGP30. The i2c component schema will need updating to add the
tvoc
type