Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition for Sensirion SGP30 #129

Merged
merged 4 commits into from Jul 14, 2023
Merged

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jul 13, 2023

@brentru @lorennorman
There's a minor hiccup:
The schema for the i2c component subtypes doesn't have TVOC, but it is included in the Adafruit_Sensor repo, so I assume that's the correct value to use, along with eco2 for the SGP30. The i2c component schema will need updating to add the tvoc type

@lorennorman
Copy link
Contributor

@tyeth perfect, thanks for this work and the note.

I've just added a commit with the tvoc sensorType added, that validation step should pass now. I'm going to go look in our other repos and see if there's other places i need to account for it.

@brentru I was looking at this list to see what all sensor types are in there:
https://github.com/adafruit/Adafruit_Sensor#standardised-si-values-for-sensors_event_t

We don't seem to be one-for-one with that list, is that expected? Or should we try to match that closely?

@lorennorman
Copy link
Contributor

lorennorman commented Jul 13, 2023

Other places to update:

@tyeth
Copy link
Contributor Author

tyeth commented Jul 13, 2023

Seen the file size image issue, woops forgot that bit, only remembered a limit for GIFs.
Will carry on in the morning

@tyeth
Copy link
Contributor Author

tyeth commented Jul 13, 2023

@lorennorman I no longer have the ability to rerun due to your commit touching restricted files, but should be fine.

@brentru
Copy link
Member

brentru commented Jul 14, 2023

@lorennorman @tyeth Enumerated type for TVOC has been added within WipperSnapper_Protobuf and wrappers have been compiled and merged into WipperSnapper_Arduino.

@lorennorman lorennorman merged commit 55c5ca1 into adafruit:main Jul 14, 2023
12 checks passed
@brentru
Copy link
Member

brentru commented Jul 14, 2023

@tyeth You should be un-blocked and able to continue. Please leave @lorennorman and I any notes in here if you are still encountering issues with the broker/types

Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants