Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added working python3.7 patch #223

Merged
merged 1 commit into from
May 24, 2021
Merged

Added working python3.7 patch #223

merged 1 commit into from
May 24, 2021

Conversation

evaherrada
Copy link
Collaborator

First one didn't work. I've tested this one locally with --dry-run and it does work and only fails on libraries that don't have a build.yml

@evaherrada evaherrada requested a review from tannewt May 24, 2021 14:15
tannewt
tannewt approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It may have needed the context lines.

@evaherrada evaherrada merged commit 8da89ce into master May 24, 2021
@evaherrada evaherrada deleted the python-patch-2 branch May 24, 2021 15:27
@kattni kattni mentioned this pull request Jun 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evaherrada @tannewt