Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combadge example only plays once for CP Classic (AVR) #28

Closed
caternuson opened this issue Dec 8, 2017 · 2 comments
Closed

Combadge example only plays once for CP Classic (AVR) #28

caternuson opened this issue Dec 8, 2017 · 2 comments

Comments

@caternuson
Copy link
Contributor

This line added a pin config change to end():
https://github.com/adafruit/Adafruit_CircuitPlayground/blob/master/utility/Adafruit_CPlay_Speaker.cpp#L41
and nothing in the loop() of the combadge example turns it back to output.

Example sketch can be fixed by adding a call to .speaker.begin() in the loop(), but not sure if this behavior change was intended for the library.

@caternuson
Copy link
Contributor Author

Looks like it was some of the refactoring from begin() to playSound() here:
https://github.com/adafruit/Adafruit_CircuitPlayground/blob/master/utility/Adafruit_CPlay_Speaker.cpp#L74
That used to just call begin() which would set the pin back to output.

@PaintYourDragon
Copy link
Contributor

Fixed now (1.8.2 or later), thanks for spotting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants