Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in Adafruit_CPlay_Speaker::set() #34

Closed
manitou48 opened this issue Mar 20, 2018 · 5 comments
Closed

bug in Adafruit_CPlay_Speaker::set() #34

manitou48 opened this issue Mar 20, 2018 · 5 comments
Assignees
@PaintYourDragon

Comments

@manitou48
Copy link

manitou48 commented Mar 20, 2018 •
edited
Loading

in Adafruit_CPlay_Speaker::set() in Adafruit_CPlay_Speaker.cpp, i believe
TCCR4A = value;
should be changed to OCR4A = value;

Also in talkie.cpp in Adafruit_CPlay_Speaker::say() change TCCR4A = 0x7F; to OCR4A = 0x7F;
@ladyada
Copy link
Member

ladyada commented Mar 20, 2018

we'll take a look at this too!

@mike2nl
Copy link

mike2nl commented Jan 16, 2019

@ladyada
how is the status on that because i will do some game things with sound.

@ladyada
Copy link
Member

ladyada commented Jan 21, 2019 •
edited
Loading

@mike2nl hiya - whats not working?

@adafruit adafruit deleted a comment from MikeNL Jan 21, 2019
@ladyada
Copy link
Member

ladyada commented Jan 21, 2019

@mike2nl ^

@PaintYourDragon
Copy link
Contributor

Quite right, fixed in 1.8.3 release now, thanks for spotting that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaintYourDragon PaintYourDragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PaintYourDragon @ladyada @manitou48 @mike2nl