Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed some details in the names of the "Seeed Studio XIAO ESP32C3" and "Seeed Studio XIAO ESP32C6" boards. #1438

Closed
wants to merge 2 commits into from

Conversation

Carla-Guo
Copy link

We noticed that we couldn't find these two boards by searching for "ESP32-C3" and "ESP32-C6".So it needed a change in the title of these two boards, changing "ESP32C3" to "ESP32-C3" and "ESP32C6" to "ESP32-C6". Thank you!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We go by the manufacturer's name, and Seeed chooses not to include the hyphens. See https://www.seeedstudio.com/catalogsearch/result/?q=xiao . So I don't think we should change these names. There are other boards with similar non-canonical names, such as the "Lolin C3 Mini" or Unexpected Maker "TinyC6". We would not change the name of the "TinyC6 "to the "Tiny ESP32-C6".

So I don't think we should take this PR, sorry.

If you search for "C6", you can find the board. You can also click on "Filters" and choose "esp32c6" as the Processor family.

@Carla-Guo
Copy link
Author

Carla-Guo commented Jul 23, 2024

Hello @dhalbert
I apologize for not making my personal information clear, I do in fact work for Seeed Studio, and this change was agreed to by the company.
Best Regards,
Carla

@Carla-Guo Carla-Guo requested a review from dhalbert July 23, 2024 12:17
@dhalbert
Copy link
Collaborator

@Carla-Guo Thanks. Are you going to change the product names on your website too? Or is this only for getting the search to work on https://circuitpython.org ? If we had a different search mechanism that matched "ESP32-C3" with "ESP32C3", would you be requesting this change? I am concerned about the inconsistency between the official name and the name we are using here.

I think many people would just search for "C3" or "C6", and then the boards would be easily found.

@Carla-Guo
Copy link
Author

@dhalbert Thank you,
Yes, this is just for getting the search to work on https://circuitpython.org/, and if there is different search mechanism that matched "ESP32-C3" with "ESP32C3",we will not request this change, and if you can do that mechanism, it's much appreciated!

@dhalbert
Copy link
Collaborator

We have merged #1439. Try searching for esp32-c6 now in https://circuitpython.org/downloads. You should see the Seeed Studio board. You may need to do a shift-reload in the browser to get the new Javawscript.

@dhalbert dhalbert closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants