Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nRF touchio implementation to shared modules #1517

Closed
tannewt opened this issue Feb 4, 2019 · 6 comments
Closed

Move nRF touchio implementation to shared modules #1517

tannewt opened this issue Feb 4, 2019 · 6 comments
Assignees
Milestone

Comments

@tannewt
Copy link
Member

tannewt commented Feb 4, 2019

It can be used generically.

@tannewt tannewt added this to the Long term milestone Feb 4, 2019
@nickzoic
Copy link

nickzoic commented Feb 5, 2019

Yeah, there's no particular reason which makes this specific to nRF.

I'd also say if I was going to rewrite this I'd use a timer or interrupt handler on the falling edge of the pin instead of busy-waiting. The current way is crude but effective :-/, given the microsecond timing involved not all bad but it'd be worth trying to be a little more clever ...

@tannewt
Copy link
Member Author

tannewt commented Feb 5, 2019

Crude but effective is also more portable. We currently don't have a common way of doing timers and interrupts across ports.

@nickzoic
Copy link

nickzoic commented Feb 5, 2019 via email

@tannewt
Copy link
Member Author

tannewt commented Feb 6, 2019

Yup, we can add an abstraction when it'd be useful.

@dhalbert dhalbert self-assigned this Aug 17, 2019
@dhalbert dhalbert changed the title Move nRF touch implementation to shared modules Move nRF touchio implementation to shared modules Aug 18, 2019
@ladyada
Copy link
Member

ladyada commented Aug 25, 2019

@dhalbert this is done right?

@dhalbert
Copy link
Collaborator

@ladyada Yes, it's been merged, available in the latest S3 builds for both nRF and SAMD51.

@ladyada ladyada closed this as completed Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants