-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move nRF touchio implementation to shared modules #1517
Comments
Yeah, there's no particular reason which makes this specific to nRF. I'd also say if I was going to rewrite this I'd use a timer or interrupt handler on the falling edge of the pin instead of busy-waiting. The current way is crude but effective :-/, given the microsecond timing involved not all bad but it'd be worth trying to be a little more clever ... |
Crude but effective is also more portable. We currently don't have a common way of doing timers and interrupts across ports. |
Crude but effective is also more portable. We currently don't have a> common way of doing timers and interrupts across ports.
Yeah, that's true: I went with the simplest possible approach since I
hadn't really looked at the GPIOTE functionality yet.
It might be worth developing some kind of abstraction though, in the
longer run ...
|
Yup, we can add an abstraction when it'd be useful. |
@dhalbert this is done right? |
@ladyada Yes, it's been merged, available in the latest S3 builds for both nRF and SAMD51. |
It can be used generically.
The text was updated successfully, but these errors were encountered: