stm32f405 has sdioio module as sdio

[jerryneedell]

Was the name of sdioio changed to sdio recently? the docs still refer to it as sdioio but in the rc.1 build for the STM32F405, it shows up (and works) as sdio instead of sdioio.

Is this correct?

Adafruit CircuitPython 7.0.0-rc.1-72-g9b2d8ade2 on 2021-09-14; Adafruit Feather STM32F405 Express with STM32F405RG
>>> 
>>> help('modules')
__main__          board             math              sharpdisplay
_bleio            builtins          microcontroller   storage
adafruit_bus_device                 busio             micropython       struct
adafruit_pixelbuf canio             msgpack           supervisor
aesio             collections       neopixel_write    synthio
alarm             digitalio         onewireio         sys
analogio          displayio         os                terminalio
array             errno             pulseio           time
atexit            fontio            pwmio             touchio
audiocore         framebufferio     rainbowio         traceback
audiomp3          gc                random            ulab
audiopwmio        getpass           re                usb_cdc
binascii          io                rgbmatrix         usb_hid
bitbangio         json              sdcardio          usb_midi
bitmaptools       keypad            sdio              vectorio
Plus any modules on the filesystem
>>> 

this example works on the STM32F405

import os
import board
import sdio
import storage
import sys
sd = sdio.SDCard(clock=board.SDIO_CLOCK,command=board.SDIO_COMMAND,data=board.SDIO_DATA,frequency=25000000)
vfs = storage.VfsFat(sd)
storage.mount(vfs, '/sd')
sys.path.append("/sd")
sys.path.append("/sd/lib")

[microdev1]

Good catch @jerryneedell. This change was introduced in 9002f35, it is probably a mistake.

[jerryneedell]

Good catch @jerryneedell. This change was introduced in 9002f35, it is probably a mistake.

Ah -- good -- I've been trying to find another port that has it enabled to compare, but have not found one yet. IT is in the "common-hal" for atmel-samd but it appears to be disabled in the build.

[jerryneedell]

Is it just this line

circuitpython/shared-bindings/sdioio/__init__.c

Line 49 in 9002f35

MP_REGISTER_MODULE(MP_QSTR_sdio, sdioio_module, CIRCUITPY_SDIOIO);

missing the "io" in the MP_QSTR_sdio

[microdev1]

Yup, that is the only line that needs to be changed.

- MP_REGISTER_MODULE(MP_QSTR_sdio, sdioio_module, CIRCUITPY_SDIOIO);
+ MP_REGISTER_MODULE(MP_QSTR_sdioio, sdioio_module, CIRCUITPY_SDIOIO);

[jerryneedell]

I can do a PR later today, but it may be a lot quicker for someone else to do it.

[dhalbert]

I just did a quick PR.

[jerryneedell]

Thanks -- it works!