Fix unaligned disk reads properly #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround is no longer needed, so it can be removed. Closes: adafruit#2332
|
Alternately, I could do this in the nrfx submodule, which would also benefit arduino. Let me know, while I'm fresh from implementing this would be a good time to take it upstream instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset improves spi_flash_read_data so that it handles unaligned (and non-multiple-of-4) disk reads. It also adds a note that writes MAY need this handling too; however, I think without checking that oofatfs will never actually generate such writes. It also removes the workaround that was the initial band-aid fox for #2332.