STM32: Add PulseOut support #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the implementations of the NRF and Atmel ports. TIM7 is used as it does not have a tied pin. Contains some register micromanagement since HAL support for the TIM7 timer is limited.
tannewt
previously approved these changes
Mar 3, 2020
|
@tannewt could you re-approve after the CI clears? It cancelled some checks for some reason and I dismissed your review trying to get it to restart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadly matches the implementations of the NRF and Atmel ports. Uses the STM32 TIM7 peripheral, a basic timer that is not tied to any pins - since the HAL support for the basic timers is limited, contains a little more register micromanagement than usual. Tested on STM32F405 Feather.
I used the basic timers for this implementation since I figured it would maximize the exposure of timers for PWM pins, but I missed that they're not available on low end Access Line boards such as the F401 and F411. Since the basic timers have a different register implementation than standard timers I think it's best if I patch in support for those sets of boards later.