STM32: add PulseIn module #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tannewt could you check out the CI on this? I'm not sure how to get it to restart properly. It passed the failed tests previously. |
|
i restarted the jobs, but the checkout failed again. @hierophect could you maybe merge from upstream and push again? |
|
@dhalbert it cancelled itself again but it's on a board that passed previously - it's passed every test at this point, it just can't seem to do them all at once. |
tannewt
requested changes
Mar 12, 2020
|
@tannewt revised, thanks! |
tannewt
approved these changes
Mar 12, 2020
jepler
pushed a commit
to jepler/circuitpython
that referenced
this pull request
Aug 27, 2021
Addresses issues adafruit#2697 and adafruit#5329. Signed-off-by: Damien George <damien@micropython.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the PulseIn module to the STM32 port, used for IR pulse reading. Tested on the Feather STM32F405 and PybNano V2 - records the same data as a control M4 Express, and sends trigger pulses of the correct duration. Currently handles all interrupts generated by EXTI - if external interrupts are eventually used for power wakeup, some of this HAL-level code may need to be factored out into Microcontroller or a similar shared location.