Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMD51: change of DAC power setting #3880

Merged
merged 1 commit into from Dec 25, 2020
Merged

SAMD51: change of DAC power setting #3880

merged 1 commit into from Dec 25, 2020

Conversation

digixx
Copy link

@digixx digixx commented Dec 25, 2020

Fixes wrong DAC output levels at high data rate
closes #3796

Fixes wrong DAC output levels at high data rate
closes #3796
@ladyada ladyada requested a review from jepler December 25, 2020 17:00
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got the present setting when I tried copying Arduino register settings to CircuitPython: 61698eb

The mismatch between the associated GCLK and the register setting was noted in that commit.

Before that, it appears we used GCLK5 at 2MHz and used DAC_DACCTRL_CCTRL_CC1M which was "correct" (1M is for 1.2MHz < GCLK_DAC ≤ 6MHz)

I don't know whether I made an error selecting the combination of CC100K and 12MHz, or whether that is truly what Arduino does--a quick grep in Adafruit's ArduinoCore-samd didn't give me the answer.

This seems "correct" and the submitter has tested it, so let's give this a try. We'll have at least one beta to check it out in.

Testing performed: none

@jepler jepler merged commit 5c4cb43 into adafruit:main Dec 25, 2020
@jepler
Copy link
Member

jepler commented Dec 26, 2020

Thank you @digixx .

@digixx digixx deleted the patch-1 branch December 26, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audioio.AudioOut(board.A0) using audiocore.RawSample() create wrong waveforms
2 participants