ESP32-S2: Log all Wi-Fi events & remove unneeded call #3903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init.c:
Add logging to the event handler default event to capture any other wi-fi events that occur, to see what else happens in the field that we may want to handle better.
Radio.c:
This call in
start_station()
:has the wrong parameter [type] (should be
ESP_IF_WIFI_STA
== 0;WIFI_MODE_STA
== 1 and sets the config for AP interface type ), and is also not needed here since it's called inconnect()
anyway (and is not needed for scanning or ping).Alternatively, we could correct the call in
start_station()
, and remove it fromconnect()
(connect()
callsstart_station()
)All depends on the design intent... how granular we want these functions to be as features like AP, AP+STA, etc. get added. It might be nice to keep clean code demarcation between concepts of netif [de]init, wifi [de]init, wi-fi mode, wifi start/stop, and station [dis]connect.