Fix write_then_readinto in adafruit_bus_device I2CDevice

[gamblor21]

If the out_end optional keyword was omitted the keyword array skipped to indexes leading to parsing confusion.

[jerryneedell]

Tested fix with si7021 on MAgTag
It was failing prior to fix with:

Press any key to enter the REPL. Use CTRL-D to reload.

Adafruit CircuitPython 6.2.0-beta.1-127-ga10ce39ae on 2021-02-06; Adafruit MagTag with ESP32S2
>>> 
>>> import board
>>> import adafruit_si7021
>>> sht = adafruit_si7021.SI7021(board.I2C())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "adafruit_si7021.py", line 110, in __init__
  File "adafruit_si7021.py", line 107, in __init__
  File "adafruit_si7021.py", line 107, in __init__
TypeError: extra keyword arguments given
>>> 

with this PR it works normally

[jerryneedell]

odd behavior with this PR -- not sure if it is related to the PR...
It works normally after a power cycle, but not after a soft reboot.

Press any key to enter the REPL. Use CTRL-D to reload.

Adafruit CircuitPython 6.2.0-beta.1-14-gea4a12005-dirty on 2021-02-06; Adafruit MagTag with ESP32S2
>>> import board,adafruit_si7021
>>> sht = adafruit_si7021.SI7021(board.I2C())
>>> 
soft reboot

Auto-reload is on. Simply save files over USB to run them or enter REPL to disable.


Code done running.

Press any key to enter the REPL. Use CTRL-D to reload.

Adafruit CircuitPython 6.2.0-beta.1-14-gea4a12005-dirty on 2021-02-06; Adafruit MagTag with ESP32S2
>>> 
>>> import board,adafruit_si7021
>>> sht = adafruit_si7021.SI7021(board.I2C())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "adafruit_si7021.py", line 99, in __init__
ValueError: No I2C device at address: 40
>>> 

[jepler]

This makes sense, but I didn't do any testing.

[jerryneedell]

the issue with the soft reboot is reproducible on a metro_esp32s2 but it does not occur on a PyPortal
I'll open a new issue for that

[dhalbert]

@jerryneedell Is this particular PR good to merge, or are you still investigating?

[dhalbert]

@gamblor21 says good to merge.