Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audiocore] buffer_read was never used #4338

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

tyomitch
Copy link
Collaborator

@tyomitch tyomitch commented Mar 5, 2021

No description provided.

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 5, 2021

@tyomitch Are you doing a by-hand code audit, or are you using a tool? Could you consolidate these and future small changes into one or a few PR's? Thanks. Each PR generates about 40 minutes of CI time.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change compiles, it seems like it has to be right.

@jepler
Copy link
Member

jepler commented Mar 5, 2021

Thank you

@jepler jepler merged commit 2881699 into adafruit:main Mar 5, 2021
@tyomitch tyomitch deleted the patch-2 branch March 6, 2021 07:18
@tyomitch
Copy link
Collaborator Author

@tyomitch Are you doing a by-hand code audit, or are you using a tool?

That was not intended as a code audit; just the few rough spots I came across while working on #4399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants