build.yml: Fix 'Print failure info' to not error #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Mar 5, 2021
jepler
force-pushed
the
fix-ci-failure-info
branch
from
8cbbee9
to
6e01c09
Compare
|
I was unable to determine whether the CI is guaranteed to run with the bash as the shell. The snippet above is intended to work with any sh. If it's guaranteed to be bash, then nullglob is a better solution. |
dhalbert
requested changes
Mar 5, 2021
Print Failure Info is for printing differences detected by 'Test all'. When some other step fails, then "*.exp" doesn't match any files at all, and _this_ step fails too. We will assume that Github Actions always runs with bash as the shell (as it does today). In this case, we can set the "nullglob" shell option, so that a non-existent glob expands to nothing, instead of to itself.
jepler
force-pushed
the
fix-ci-failure-info
branch
from
6e01c09
to
f7e42bf
Compare
|
The shell is bash now, and can't be changed lightly without breaking workflows, so let's assume it. I've changed the code to set the nullglob shell option instead of using the complicated and portable way. |
|
Build failure is a network glitch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print Failure Info is for printing differences detected by 'Test all'. When some other step fails, then "*.exp" doesn't match any files at all, and this step fails too.
We will assume that the shell is bash and use the easy "shopt" way of fixing the problem, so that ".exp" expands to nothing (instead of ".exp") if there are no matches.
This is an alternative to #4334, which would remove the step entirely. It is undesirable to do that, as we wouldn't be able to see the information about the failures that occurred anymore.