Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Franzininho wifi ESP32-S2 Wrover #4348

Merged
merged 13 commits into from
Mar 9, 2021

Conversation

FBSeletronica
Copy link

Hello all!

I'm adding a port for Franzininho WiFi Board with the ESP32-S2 wrover module. I followed this guide to build the port.

Please let me know if I need to make some fixes or is everything ok.

Thanks

@ajs256
Copy link

ajs256 commented Mar 6, 2021

0x239A is Adafruit's private USB Vendor ID (VID). You can get your own from USB-IF, or if your board is open-source, get one at pid.codes. I believe @tannewt is on the team there and is hinting people in that direction.

@FBSeletronica
Copy link
Author

0x239A is Adafruit's private USB Vendor ID (VID). You can get your own from USB-IF, or if your board is open-source, get one at pid.codes. I believe @tannewt is on the team there and is hinting people in that direction.

Sorry, I forgot to change VID in mpconfigboard.mk. Now It is ok. Thank you

.github/workflows/build.yml Show resolved Hide resolved
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Don't forget to add your boards to https://github.com/adafruit/circuitpython-org too!

@tannewt tannewt merged commit d650849 into adafruit:main Mar 9, 2021
@FBSeletronica
Copy link
Author

Thanks! Don't forget to add your boards to https://github.com/adafruit/circuitpython-org too!

@tannewt thank you. Now I will add the boards to the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants