Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor displayio set_pixel for use in bitmap_tools #4357

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

kmatch98
Copy link
Collaborator

@kmatch98 kmatch98 commented Mar 7, 2021

This refactors _set_pixel function into its two main functions, updating the dirty area and writing the pixel. This allow reuse of the _set_dirty_area and _write_pixel with other bitmap manipulation functions (and providing a minor speedup to _blit).

I updated the _blit function to use these new sub-functions.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@kmatch98
Copy link
Collaborator Author

kmatch98 commented Mar 7, 2021

I forgot to mention. I ran make translateand the diff showed one entry that was removed “ Group full.” I didn’t touch that file so maybe this is some leftover from Deshipu’s group update to displayio?

Let me know if I need to add the locale/circuitpython.pot to this PR.

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 7, 2021

Groups no longer have a limit, so that makes perfect sense.

@jepler
Copy link
Member

jepler commented Mar 7, 2021

.. and the translation check only signals an error in the case of NEW messages, not REMOVED ones. This is perhaps unexpected, but it's what the code says.

@jepler jepler merged commit 8f64aae into adafruit:main Mar 7, 2021
@kmatch98
Copy link
Collaborator Author

kmatch98 commented Mar 7, 2021

Thanks for clarifying. (I was mainly worried that my poor git skills somehow caused it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants