-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caveat for usb_cdc.Serial.connected; fix another doc bug #4359
Conversation
adf9233
to
8594396
Compare
Loosely related to issue #4345: The usb_cdc documentation (https://circuitpython.readthedocs.io/en/latest/shared-bindings/usb_cdc/index.html) is missing the following methods :
Aditionally, it is missing any information about how to change the newline character, if possible at all. |
@dhalbert I think this is good to go but I'm leaving un-merged in case you want to make any change related to @ismael-miguel's review comment (and the build's not finished anyway) |
1c3a274
to
a147e74
Compare
a147e74
to
24ac815
Compare
Anybody can review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Fixes #4345.
Fixes #4352.
These are documentation changes only.