Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up a bit more #4393

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 13, 2021

The goldilocks of flash speeds. / 2 is too fast and / 6 is slower than needed. It doesn't need to be divisible by 2.

@tannewt tannewt requested a review from jepler March 13, 2021 00:02
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, no testing performed, but does what it says.

@dhalbert
Copy link
Collaborator

@caternuson Could you test this on the board you had trouble with? Thanks.

@FoamyGuy
Copy link
Collaborator

I had the issue from #4377 on both of my Feather RP2040 devices. I tried out the build from the artifact of this PRs actions and can confirm it does seem to resolve the issue for me.

This is my boot_out after loading this version:

Adafruit CircuitPython 6.2.0-beta.3-144-g737063c19 on 2021-03-13; Adafruit Feather RP2040 with rp2040

I tested on both devices and have successfully reset several times with the button, as well as unplug / replug. I have about a dozen trials between both devices and have not seen the issue come up again since loading this firmware.

@caternuson
Copy link

@dhalbert Tested and works on the two Feather RP2040s I have.

@dhalbert
Copy link
Collaborator

Thanks @caternuson. I will merge.

@dhalbert dhalbert merged commit 8e425a9 into adafruit:main Mar 13, 2021
@ladyada
Copy link
Member

ladyada commented Mar 14, 2021

thanks :)

@anecdata anecdata added the rp2 Raspberry Pi RP2 Micros label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rp2 Raspberry Pi RP2 Micros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants