Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed confusing error messages. #4543

Merged
merged 2 commits into from
Apr 3, 2021
Merged

Changed confusing error messages. #4543

merged 2 commits into from
Apr 3, 2021

Conversation

bergdahl
Copy link

@bergdahl bergdahl commented Apr 2, 2021

Changed error message to display the generic term 'system firmware' instead of the Nordic specific term 'soft device' as suggested by @dhalbert.

@bergdahl
Changed error message to display the generic term 'system firmware' i…
1afd204 
…nstead of the Nordic specific term 'soft device'
dhalbert
dhalbert previously approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the jargon and fixing it!

@jposada202020
Copy link
Collaborator

@bergdahl Thanks :)

@dhalbert
Copy link
Collaborator

dhalbert commented Apr 2, 2021

Do a make translate and commit and push again. That's often necessary when messages change.

@dhalbert dhalbert merged commit 3af02b6 into adafruit:main Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bergdahl @jposada202020 @dhalbert