[qstr] Separate hash and len from string data #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the compiler to merge strings: e.g. "update", "difference_update" and "symmetric_difference_update" will all point to the same memory. Shaves ~1KB off the image size, and potentially allows bigger savings if qstr attrs are initialized in qstr_init(), and not stored in the image.
tannewt
approved these changes
Apr 9, 2021
|
It's safe to say I don't entirely follow what has been done, but it gained us 200 bytes on trinket_m0 and apparently it works (I didn't test it for myself). It might be worth offering this change to MicroPython as well, if you feel like it. |
tyomitch
added a commit
to tyomitch/circuitpython
that referenced
this pull request
May 3, 2021
This allows the compiler to merge strings: e.g. "update",
"difference_update" and "symmetric_difference_update"
will all point to the same memory.
No functional change.
```
bare-arm: -12 -0.021%
minimal x86: +38 +0.026% [incl +40(data)]
unix x64: -576 -0.114% [incl +32(data)]
unix nanbox: -696 -0.158%
stm32: -1336 -0.344% PYBV10
cc3200: -440 -0.240%
esp8266: -1092 -0.159% GENERIC
esp32: -1332 -0.093% GENERIC[incl -1408(data)]
nrf: -404 -0.273% pca10040
rp2: -1024 -0.213% PICO
samd: -196 -0.190% ADAFRUIT_ITSYBITSY_M4_EXPRESS
```
Originally at adafruit#4583
Signed-off-by: Artyom Skrobov <tyomitch@gmail.com>
tyomitch
added a commit
to tyomitch/circuitpython
that referenced
this pull request
May 6, 2021
This allows the compiler to merge strings: e.g. "update",
"difference_update" and "symmetric_difference_update"
will all point to the same memory.
No functional change.
```
bare-arm: -12 -0.021%
minimal x86: +38 +0.026% [incl +40(data)]
unix x64: -576 -0.114% [incl +32(data)]
unix nanbox: -696 -0.158%
stm32: -1336 -0.344% PYBV10
cc3200: -440 -0.240%
esp8266: -1092 -0.159% GENERIC
esp32: -1332 -0.093% GENERIC[incl -1408(data)]
nrf: -404 -0.273% pca10040
rp2: -1024 -0.213% PICO
samd: -196 -0.190% ADAFRUIT_ITSYBITSY_M4_EXPRESS
```
Originally at adafruit#4583
Signed-off-by: Artyom Skrobov <tyomitch@gmail.com>
micropython#7209 pending review since May 3rd -- would anybody like to help them review it? |
dpgeorge
pushed a commit
to micropython/micropython
that referenced
this pull request
Feb 11, 2022
This allows the compiler to merge strings: e.g. "update",
"difference_update" and "symmetric_difference_update" will all point to the
same memory.
No functional change.
The size reduction depends on the number of qstrs in the build. The change
this commit brings is:
bare-arm: -4 -0.007%
minimal x86: +150 +0.092% [incl +48(data)]
unix x64: -608 -0.118%
unix nanbox: -572 -0.126% [incl +32(data)]
stm32: -1392 -0.352% PYBV10
cc3200: -448 -0.244%
esp8266: -1208 -0.173% GENERIC
esp32: -1028 -0.068% GENERIC[incl -1020(data)]
nrf: -440 -0.252% pca10040
rp2: -1072 -0.217% PICO
samd: -368 -0.264% ADAFRUIT_ITSYBITSY_M4_EXPRESS
Performance is also improved (on bare metal at least) for the
core_import_mpy_multi.py, core_import_mpy_single.py and core_qstr.py
performance benchmarks.
Originally at adafruit#4583
Signed-off-by: Artyom Skrobov <tyomitch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the compiler to merge strings: e.g. "update",
"difference_update" and "symmetric_difference_update"
will all point to the same memory.
Shaves ~1KB off the image size, and potentially allows
bigger savings if qstr attrs are initialized in qstr_init(),
and not stored in the image.