Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving design guide #4643

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Improving design guide #4643

merged 4 commits into from
Apr 21, 2021

Conversation

jposada202020
Copy link
Collaborator

Changes:

  • Small corrections,
  • Adding examples requirements in the design guide
  • SI units corrections and clarifications.
  • Using :const: and Defaults to in class documentation.
  • Building reference change.

jposada202020 and others added 4 commits March 18, 2021 21:35
@jposada202020
Merge pull request #1 from adafruit/main
ac232f2 
update
@jposada202020
Merge pull request #2 from adafruit/main
cd7f5fe 
From Main
@jposada202020
Merge pull request #3 from adafruit/main
22b72ad 
From Main
@jposada202020
Small corrections, adding examples requirements in the design guide. …
b825368 
…SI units corrections and clarifications. Using const and Defaults to in class documentation. Building reference change.
@jposada202020
Copy link
Collaborator Author

@kattni As discussed. First set of changes. Thank you.

@tannewt tannewt requested review from caternuson and tannewt and removed request for caternuson April 21, 2021 22:29
tannewt
tannewt approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 7a47213 into adafruit:main Apr 21, 2021
@jposada202020 jposada202020 deleted the improving_design_guide branch April 21, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jposada202020 @tannewt