-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor docs fixes in displayio.Bitmap #4651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sphinx syntax is not obvious; it's not markdown, though sometimes it looks like that. You'll want to try to build to docs locally to make sure any changes will work, such as the new cross-reference you propose.
I agree that Sphinx is not obvious in what is the best way to highlight things as code and cross-reference to other documentation. I had tested a local docs build and the changes made, the single quotes, get rid of the red links (generally interpreted as errors or missing links) that are currently on the website . I can rechange these back if you prefer but I think that |
With your changes, these new warnings below are generated during
We try to avoid warnings. If we changed double-backtick to single-backtick everywhere, we'd have hundreds of these. Sphinx is trying to do a cross reference from the text in single backquotes. The RST doc explains the difference:
in red may not be the best choice, but that's just the CSS style. We use double-backquotes all over the place for |
Weird. I've pushed those changes but I'm not sure if they've pulled over to the PR. |
Yes, there's something weird with GitHub. Yours was your first PR against |
Try committing and pushing again; I think you can do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.