New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MagTag: Remove board.SPI(); rename display-only pins #4695

Merged

dhalbert merged 1 commit into adafruit:main from dhalbert:magtag-spi-naming

May 1, 2021

Collaborator

dhalbert commented May 1, 2021

On the MagTag, board.SPI() can only be used for the display; the pins are not broken out elsewhere. Using board.SPI() gives a "pin in use" error.

Remove board.SPI().
Rename board.MOSI, .MISO, .SCK to .EPD_MOSI, etc.
Remove board.CS; it already has an alias EPD_CS.

Fixes #4142.


          MagTag: Remove board.SPI(); rename display-only pins

670c49e

dhalbert requested review from ladyada and anecdata

May 1, 2021 03:02

anecdata approved these changes

View reviewed changes

Member

anecdata left a comment

It makes sense functionally that board shouldn't advertise capabilities that aren't exposed. The RTD warning in board says as much:

The board module varies by board. The APIs documented here may or may not be available on a specific board.

anecdata mentioned this pull request

MagTag: board.SPI() returns "SCK in use" #4142

Closed

dhalbert merged commit ebedeeb into adafruit:main

dhalbert deleted the magtag-spi-naming branch

May 1, 2021 13:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment