New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check of usb_hid.Device out_report_length #4819

Merged

dhalbert merged 1 commit into adafruit:main from dhalbert:fix-out_report_length

May 28, 2021

Collaborator

dhalbert commented May 28, 2021

The out_report_length arg for the usb_hid.Device constructor was checked to be 1-255 instead of 0-255. There was also a bug of what type the arg was, which meant that an arg of 0 was interpreted as 1, so the check was not triggered. Fixed.
Check the the report_id_index is in range, not past the end of the report.

Tested by @ATMakersBill.


          fix check of usb_hid.Device out_report_length

e7f82f8

dhalbert requested review from tannewt and jepler

May 28, 2021 01:33

jepler approved these changes

View reviewed changes

Member

jepler left a comment

No testing performed, but seems to do what the PR description says.

dhalbert merged commit fdc7f5f into adafruit:main

dhalbert deleted the fix-out_report_length branch

May 28, 2021 02:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment