Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bit_length() method to work with zero-valued mpz integer. #4845

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fix bit_length() method to work with zero-valued mpz integer. #4845

merged 2 commits into from
Jun 2, 2021

Conversation

t-ikegami
Copy link

The following code crashes CircuitPython 6.2 (tested on Wio Terminal) :

a = 10**10
a *= 0
a.bit_length()

This PR fixes the problem.

jepler
jepler approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jepler jepler mentioned this pull request Jun 2, 2021
Closed
@tannewt tannewt merged commit a25872d into adafruit:main Jun 2, 2021
kbsriram added a commit to kbsriram/circuitpython that referenced this pull request Feb 18, 2024
@kbsriram
Add tests for bit_length()
e675ea3 
Also verified the tests fail without the fix in adafruit#4845
Fixes adafruit#4846
@kbsriram kbsriram mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-ikegami @jepler @tannewt