Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tinyusb to fix nrf control race condition #4900

Merged
merged 2 commits into from
Jun 21, 2021
Merged

update tinyusb to fix nrf control race condition #4900

merged 2 commits into from
Jun 21, 2021

Conversation

hathach
Copy link
Member

@hathach hathach commented Jun 18, 2021 •
edited

fix race condition with control since TASKS_EP0RCVOUT also require EsyDMA. Should fix #4894 and fix #4440 .

@hathach hathach requested a review from dhalbert June 18, 2021 19:29
@hathach hathach mentioned this pull request Jun 18, 2021
Closed
@jepler
Copy link
Member

jepler commented Jun 19, 2021 •
edited

Looks like all the xtensa builds fail,

make: *** No rule to make target 'lib/tinyusb/src/portable/espressif/esp32s2/dcd_esp32s2.c',
    needed by 'build-adafruit_feather_esp32s2_nopsram/genhdr/qstr.split'.  Stop.

are additional changes needed there?

@hathach
Copy link
Member Author

hathach commented Jun 19, 2021

Looks like all the xtensa builds fail,

make: *** No rule to make target 'lib/tinyusb/src/portable/espressif/esp32s2/dcd_esp32s2.c',
    needed by 'build-adafruit_feather_esp32s2_nopsram/genhdr/qstr.split'.  Stop.

are additional changes needed there?

Yeah, it is rename dcd_esp32sx.c to also support s3, I have pushed the commit update.

dhalbert
dhalbert approved these changes Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #4440 for me on Linux. Thanks!

@dhalbert dhalbert merged commit 624a53a into adafruit:main Jun 21, 2021
@tannewt tannewt mentioned this pull request Jun 22, 2021
Closed
@hathach hathach deleted the fix-nrf-control-race-condition branch August 12, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COM port for ItsyBitsy NRF52840 Express stopped working after 6.0.1 REPL slow to connect on nRF52
3 participants
@hathach @jepler @dhalbert