Fix for issue #4908 - pulseout leaving line high #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for figuring this out. Is there already a report of this problem somewhere else? If not, it might be worthwhile filing an issue with your observation in https://github.com/raspberrypi/pico-feedback or https://github.com/raspberrypi/pico-sdk. |
|
Does disabling PWM actually leave the pin in a know state or simply stop the counter to it? Maybe we want to force reset the pin instead of waiting a little time to hit the off phase of the pwm. |
|
I tried forcing the pin low after the pulse completed, but that did not
work reliably. Only
a delay seemed to work. I was able to reproduce the issue with a C program
using the Pico SDK,
so I will open an issue with the SDK.
…On Thu, Jun 24, 2021 at 12:41 PM Scott Shawcroft ***@***.***> wrote:
Does disabling PWM actually leave the pin in a know state or simply stop
the counter to it? Maybe we want to force reset the pin instead of waiting
a little time to hit the off phase of the pwm.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4911 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNJKERVLI3ADDKC7BQFHWDTUNU45ANCNFSM47G56LWA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently if calling pwm_set_enabled() to disable PWM is done too soon after a pulseout is ended it can leave the pin high (Issue #4908) Inserting a short delay before the call seems to resolve the issue - testing was run for several minutes without reproducing the error.