Fix 4193 - set hidden_by_parent when adding to displayio group #4915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4193 using the proposed simple solution.
When appending a layer (
Group
orTileGrid
) to adisplayio
group, set thehidden_by_parent
attribute to true if the group (the new "parent") is eitherhidden
orhidden_by_parent
. The*_set_hidden_by_parent
functions propagate the value further down the tree as necessary.This fixes in particular updating text labels while they are hidden, like you would with a pagination system, since it involves inserting one or more
TileGrid
s inside the label'sGroup
, triggering the issue.Tested on the Clue with the code from the issue and some test code updating text labels while hidden.